[PATCH] D114437: [Support][CMake] Fix exposed absolute path dependency of terminfo library

Sun Dec 5 19:06:40 PST 2021

xndcn added a comment.

In D114437#3171687 <https://reviews.llvm.org/D114437#3171687>, @compnerd wrote:

> I think that this is almost correct now.  While this will generate the binaries correctly, this is still a problem for tests.  Without the absolute path, we now run the risk of the DT_NEEDED being correct but without a DT_RPATH/DR_RUNPATH, this could pick up the wrong library still at runtime.  While the link time issue is resolved, the runtime portion is still a problem.

Thanks! Just found a similar but more elegant commit has been merged yesterday: https://reviews.llvm.org/D114327
So I will close it now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114437/new/

https://reviews.llvm.org/D114437