[PATCH] D108763: Use type sizes when determining dependence

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM with additional comments for the tests addressed.  Please also add something like `[LAA]` to the beginning of the title, so it is easier to categorise the change when reading the commit log.



================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/depend_diff_types.ll:92
+; CHECK-NEXT:            %2 = load double, double* %1, align 8 ->
+; CHECK-NEXT:		 store i19 %11, i19* %10, align 8
+; CHECK-EMPTY:
----------------
nit: formatting is off here and for other stores in this test.


================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/depend_diff_types.ll:134
+  %11 = trunc i64 %7 to i19
+  store i19 %11, i19* %10, align 8
+
----------------
can you also throw in a read or write to a 32 bit type? Might be good to move those into a separate test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108763/new/

https://reviews.llvm.org/D108763