[PATCH] D115041: [ELF] Do not report undefined weak references in shared libraries

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 4 20:37:15 PST 2021


jrtc27 added inline comments.


================
Comment at: lld/test/ELF/allow-shlib-undefined-weak.s:27
+
+CHECK-NOT: undefined reference to foo [--no-allow-shlib-undefined]
+
----------------
MaskRay wrote:
> Checking just the diagnostic can easily go stale. Use `| count 0` if the output is empty.
Might also be worth adding `--no-allow-shlib-undefined` in case the default ever changes; I meant to do that in what I posted but forgot


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115041/new/

https://reviews.llvm.org/D115041



More information about the llvm-commits mailing list