[PATCH] D113030: Add a new tool for parallel safe bisection, "llvm-bisectd".

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Support/Bisector.cpp:51-53
+  LLVM_DEBUG(dbgs() << "Starting bisect with a key map of size "
+                    << KeyStateMap.size() << "\n");
+  LLVM_DEBUG(dbgs() << "Initial bisect index = " << Counter << "\n");
----------------
Merge these into one LLVM_DEBUG() block? 


================
Comment at: llvm/lib/Support/RemoteBisectorClient.cpp:40-42
+    errs() << "RemoteBisectClient: getaddrinfo() failed: "
+           << std::strerror(errno) << "\n";
+    report_fatal_error("Fatal error.");
----------------
Can you directly use Twine to produce the full error message from report_fatal_error


================
Comment at: llvm/lib/Support/RemoteBisectorClient.cpp:59-62
+        errs() << "RemoteBisectClient: could not bind() to the socket after "
+                  "waiting: "
+               << std::strerror(errno) << "\n";
+        report_fatal_error("Fatal error.");
----------------
Ditto


================
Comment at: llvm/lib/Support/RemoteBisectorClient.cpp:65-67
+    errs() << "RemoteBisectClient: could not bind() to the socket: "
+           << std::strerror(errno) << "\n";
+    report_fatal_error("Fatal error.");
----------------
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113030/new/

https://reviews.llvm.org/D113030