[PATCH] D89492: [compiler-rt] Enable building builtins using top-level CMake file

[Kazushi Marukawa via Phabricator via llvm-commits]

kaz7 added a comment.

Hi.  Thank you for trying to achieve pre-compiling of crtbegin/crtend and builtins.  Our architecture, SX-Aurora VE, doesn't have freely distributed crtbegin/crtend, so a mechanism like this is really important as I mentioned in D115038 <https://reviews.llvm.org/D115038>.

I take a look.  I think the way to isolate each modules are good way to do.  So, basically, it's fine to land in my opinion.  However, we have been updating runtimes tramendously.  So, it's better to rebase to recent main.  We already have `compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake`.  Scope is changed like @daltenty suggested.

After that, we can review it and run it.  Thank you for your efforts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89492/new/

https://reviews.llvm.org/D89492