[PATCH] D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline.

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1267
+// Describe where a given element exists.
+std::string Colours[NumIRChangeDiffTypes];
+
----------------
mehdi_amini wrote:
> This seems like this global is mutable and I see a bunch of TSAN failures, can you look into this?
Yeah this should probably be a member variable.

But where are you seeing tsan failures? This is used for debugging and the in-tree tests for this should only be single threaded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87202/new/

https://reviews.llvm.org/D87202