[PATCH] D114558: [ASan] Shared optimized callbacks implementation.

Kirill Stoimenov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 3 13:18:41 PST 2021


kstoimenov marked an inline comment as done.
kstoimenov added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_shadow_defines.h:17
+#if !defined(SANITIZER_WORDSIZE)
+#  error "SANITIZER_WORDSIZE should be defined."
+#endif
----------------
vitalybuka wrote:
> vitalybuka wrote:
> > kstoimenov wrote:
> > > vitalybuka wrote:
> > > > why can't you move this into asan_mapping.h?
> > > I can't include asan_mapping.h from .S files.
> > Can you do an opposite? include this one into asan_mapping and use SHADOW_OFFSET_CONST there.
> > 
> this comment is unreplied
Sent in a separate patch: D115075. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114558/new/

https://reviews.llvm.org/D114558



More information about the llvm-commits mailing list