[PATCH] D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot

[Chris Matthews via Phabricator via llvm-commits]

cmatthews added a comment.

Wow, v4_graph is complex!

Thank you for breaking this up! Much easier to review.  This looks good to me now.



================
Comment at: lnt/server/ui/views.py:869
 
-def load_graph_data(plot_parameter, show_failures, revision_cache=None):
-
+def load_graph_data(plot_parameter, show_failures, limit, xaxis_date, revision_cache=None):
+    """
----------------
For functions that are being significantly changed, can you add type annotations.

We are trying to slowing introduce types into the system. I realize the original functions did not have them, but now is the time to add them. 

That could be in a later commit though, if that is easier.


================
Comment at: lnt/server/ui/views.py:1083
+
+    metrics = list(set(req.field.name for req in plot_parameters))
+
----------------
maybe metric_names?  Metric is a very overloaded term in this system!


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111289/new/

https://reviews.llvm.org/D111289