[PATCH] D114469: [XRay] fix more -Wformat warnings

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 3 12:04:32 PST 2021


vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/xray/xray_interface.cpp:172
   default:
-    Report("Unsupported sled kind '%d' @%04x\n", Sled.Address, int(Sled.Kind));
+    Report("Unsupported sled kind '%" PRIu64 "' @%04x\n", Sled.Address,
+           int(Sled.Kind));
----------------
dim wrote:
> vitalybuka wrote:
> > %llu
> This can only be done by adding a cast, as `Sled.Address` is `uint64_t`. There's a cast here anyway, so maybe another one's OK?
> 
> 
> 
I see.
PRIu64 is OK.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114469/new/

https://reviews.llvm.org/D114469



More information about the llvm-commits mailing list