[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm requested changes to this revision.
paulwalker-arm added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:476-484
+  assert(LangOpts.VScaleMin && "vscale min must be greater than 0!");
+
+  if (LangOpts.VScaleMax)
     return std::pair<unsigned, unsigned>(LangOpts.VScaleMin,
                                          LangOpts.VScaleMax);
+
   if (hasFeature("sve"))
----------------
This looks like a change of behaviour to me.  Previously the command line flags would override the "sve" default but now that only happens when the user specifies a maximum value.  That means the interface can no longer be used to force truly width agnostic values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113294/new/

https://reviews.llvm.org/D113294