[PATCH] D115002: [ASan] Changed intrisic implemenation to use PLT safe registers.

Kirill Stoimenov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 3 09:08:39 PST 2021


kstoimenov added inline comments.


================
Comment at: llvm/lib/Target/X86/X86RegisterInfo.td:437
-                              (add RAX, RCX, RDX, RSI, RDI, R9, R10, R11,
-                                   RBX, R14, R15, R12, R13, RBP, RSP)>;
 
----------------
morehouse wrote:
> Why is RSP gone now?
One reason is that it was never generated. The second reason is that it was hard to write a test for it D114558, because to write a test I would have to clobber RSP. If you have an idea how to write a test for RSP in D114558 I would be happy to bring it back, but I don't think it is worth it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115002/new/

https://reviews.llvm.org/D115002



More information about the llvm-commits mailing list