[PATCH] D114709: [Flang] Upstream conversion of the XRebox Op

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan marked 15 inline comments as done.
kiranchandramohan added a comment.

Addressed review comments.



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1781-1784
+    auto sliceOps = rebox.sliceOffset();
+    auto shiftOps = rebox.shiftOffset();
+    auto strideOps = inputStrides.begin();
+    const auto inputRank = inputStrides.size();
----------------
clementval wrote:
> 
inputStrides is a valueRange. I have kept it auto since it is an iterator for a valuerange.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114709/new/

https://reviews.llvm.org/D114709