[PATCH] D115044: [llvm] Remove out-of-date fixme from SmallVectorMemoryBuffer

[Jan Svoboda via Phabricator via llvm-commits]

jansvoboda11 created this revision.
jansvoboda11 added a reviewer: dexonsmith.
jansvoboda11 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This fixme first appeared in the codebase with the introduction of `ObjectMemoryBuffer` rG93de2a12a36feaf1e6d8ff28c76db9b6cda4e844 <https://reviews.llvm.org/rG93de2a12a36feaf1e6d8ff28c76db9b6cda4e844>, but the constructor appears to never have been templated.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115044

Files:
  llvm/include/llvm/Support/SmallVectorMemoryBuffer.h


Index: llvm/include/llvm/Support/SmallVectorMemoryBuffer.h
===================================================================
--- llvm/include/llvm/Support/SmallVectorMemoryBuffer.h
+++ llvm/include/llvm/Support/SmallVectorMemoryBuffer.h
@@ -30,12 +30,6 @@
 public:
   /// Construct an SmallVectorMemoryBuffer from the given SmallVector
   /// r-value.
-  ///
-  /// FIXME: It'd be nice for this to be a non-templated constructor taking a
-  /// SmallVectorImpl here instead of a templated one taking a SmallVector<N>,
-  /// but SmallVector's move-construction/assignment currently only take
-  /// SmallVectors. If/when that is fixed we can simplify this constructor and
-  /// the following one.
   SmallVectorMemoryBuffer(SmallVectorImpl<char> &&SV)
       : SV(std::move(SV)), BufferName("<in-memory object>") {
     init(this->SV.begin(), this->SV.end(), false);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115044.391648.patch
Type: text/x-patch
Size: 870 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211203/c687e913/attachment-0001.bin>