[PATCH] D108394: add tsan shared library

Marco Elver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 3 07:43:12 PST 2021


melver added a comment.

Hello,

If possible please use arc diff and amend to get the canonical commit message format (see git log for other commits).
Otherwise Phabricator won't be able to track the history of what's been happening.

I saw several instances of this committed to the LLVM repo without a commit message or link here and got a little confused:

  git log --oneline | grep -i 'add tsan shar\|revert tsan'
  d2b43605c96f add tsan shared lib
  45d28e3a303a Revert "add tsan shared lib"
  92c9b340be41 add tsan shared lib
  0e8862901ca5 revert tsan part for investigation
  91bfccf83733 add tsan shared library

If you don't cleanly revert a change, the next change should explain what it's fixing and why, and usually come with a new Phabricator review.
Unless you fully revert the prior change, then the original one can be reopened.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108394/new/

https://reviews.llvm.org/D108394



More information about the llvm-commits mailing list