[PATCH] D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead

[Anna Thomas via Phabricator via llvm-commits]

anna added a comment.

In D109917#3165403 <https://reviews.llvm.org/D109917#3165403>, @reames wrote:

> Thinking about it a bit, I think there are some interesting cases where we can sink something with an analyzeable side effect.  An example I came up with is a large function with out-params which are unused in the caller.

Thanks Philip. This is a definitely interesting example worth handling. Let me update the code to consider this use case and precommit some of the tests. The use case we have downstream (as mentioned is object.hashCode), but this example makes a good usecase for upstream IMO.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109917/new/

https://reviews.llvm.org/D109917