[PATCH] D114075: [IR] Split vscale_range interface

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Thanks, I left two more minor comments that I didn't spot earlier. Otherwise looks good to me.



================
Comment at: llvm/include/llvm/IR/Attributes.h:223-224
+
+  /// Returns the maximum value for the vscale_range attribute. If omitted,
+  /// this will be the minimum, or None for unbounded (0).
+  Optional<unsigned> getVScaleRangeMax() const;
----------------
s/. If omitted, this will be the minimum,//

This probably meant to say "if omitted in the textual representation of the LLVM IR attribute", but I'm not sure how that's relevant for this comment.


================
Comment at: llvm/include/llvm/IR/Attributes.h:1064-1065
+
+  /// Retrieve the maximum value of 'vscale_range'. If omitted,
+  /// this will be the minimum, or None for unbounded (0).
+  Optional<unsigned> getVScaleRangeMax() const;
----------------
Same here, please just omit that part of the comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114075/new/

https://reviews.llvm.org/D114075