[PATCH] D114946: [AArch64] Add instruction selection for strict FP

Fri Dec 3 05:24:34 PST 2021

john.brawn planned changes to this revision.
john.brawn added a comment.

In D114946#3168771 <https://reviews.llvm.org/D114946#3168771>, @craig.topper wrote:

> In D114946#3167497 <https://reviews.llvm.org/D114946#3167497>, @kpn wrote:
>
>> That flag tells front ends that strictfp will generate correct instructions. Don't set it if more work is needed for correct instructions. The support should at least have parity with X86 and SystemZ.
>
> I think `IsStrictFPEnabled` is just the SelectionDAG flag. The frontend has a separate flag `HasStrictFP`.

Yes, without HasStrictFP in the clang TargetInfo the constrained fp instrinsics won't be emitted (unless you use -fexperimental-strict-floating-point).

On an unrelated note, I've noticed that for globalisel (used at -O0 in aarch64) to work I also need to adjust a few things.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114946/new/

https://reviews.llvm.org/D114946