[PATCH] D114472: [fir] Add fir derived type runtime builder

Fri Dec 3 04:59:55 PST 2021

rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.

================
Comment at: flang/lib/Optimizer/Builder/Runtime/Derived.cpp:25
+  auto args = fir::runtime::createArguments(builder, loc, fTy, box, sourceFile,
+                                            sourceLine);
+  builder.create<fir::CallOp>(loc, func, args);
----------------
clementval wrote:
> rovka wrote:
> > This doesn't seem to match the [[ https://github.com/llvm/llvm-project/blob/4479138de8e662f0dc64a92008b126f050e18b77/flang/runtime/derived.h#L24 | prototype from the runtime]]
> It matches the runtime api file `flang/include/flang/Runtime/derived-api.h`.
Oh, oops, I didn't even notice there was no RTNAME there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114472/new/

https://reviews.llvm.org/D114472