[PATCH] D110714: [Flang][openmp] Added semantic checks for atomic construct with update clause

[Shraiysh via Phabricator via llvm-commits]

shraiysh added a comment.

Thanks for the patch Nimish. I had a few minor comments about testcases. Rest LGTM.



================
Comment at: flang/test/Semantics/omp-atomic03.f90:96
+!$omp atomic update
+   y = MAX(y, 7)
+!$omp atomic update
----------------
MAX and MIN can have more than 2 arguments (not sure about the rest). Maybe add test cases for them.


================
Comment at: flang/test/Semantics/omp-atomic04.f90:99
+   x = y + 1
+!$omp atomic
+   !ERROR: Atomic update variable 'x' not found in the RHS of the assignment statement in an ATOMIC UPDATE construct
----------------
Should probably be `!$omp atomic update` here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110714/new/

https://reviews.llvm.org/D110714