[PATCH] D114148: [fir] Add fircg.ext_embox conversion

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1658
+    unsigned sliceOffset = xbox.sliceOffset();
+    auto loc = xbox.getLoc();
+    mlir::Value zero = genConstantIndex(loc, i64Ty, rewriter, 0);
----------------
Nit: mlir::Location


================
Comment at: flang/test/Fir/convert-to-llvm.fir:1581
+  %c0 = arith.constant 0 : i64
+  %0 = fircg.ext_embox %arg0(%c0) origin %c0[%c0, %c0, %c0] substr %c0, %c0 : (!fir.ref<!fir.array<?xi32>>, i64, i64, i64, i64, i64, i64, i64) -> !fir.box<!fir.array<?xi32>>
+  return
----------------
kiranchandramohan wrote:
> Does substr have a meaning here since it applies to chars?
Nit: Did you miss this point or is having substr here OK?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114148/new/

https://reviews.llvm.org/D114148