[PATCH] D114590: [CodeGen] Emit alignment "Max Skip" operand for align directives

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 3 00:28:43 PST 2021


courbet added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:143
+  /// and are equivalent to a value of Zero.
+  uint8_t MaxBytesForAlignment = 0;
 
----------------
Is there any reason for the inconsistency between `unsigned` in `emitAlignment` and `uint8_t` here ? I don't think this struct is particularly memory-constrained, so I would just use `unsigned` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114590/new/

https://reviews.llvm.org/D114590



More information about the llvm-commits mailing list