[PATCH] D114830: [ELF] Hint -z nostart-stop-gc for __start_ undefined references

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

In D114830#3168865 <https://reviews.llvm.org/D114830#3168865>, @dblaikie wrote:

> Generally once a patch is sent for review it should remain in review until approved, rather than committed without approval - so this patch should probably be reverted until approved?

Hmm, is that standard convention? I've observed a bunch of cases where contributors put up a review as an FYI or to get some additional thoughts, but then commit if there's no feedback or objections, for patches where they would have otherwise been comfortable committing directly for post-commit review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114830/new/

https://reviews.llvm.org/D114830