[PATCH] D115019: ThreadPool: grow the pool only as needed

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 2 20:24:53 PST 2021


mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/Support/ThreadPool.h:149
+  void grow();
+
   /// Threads in flight
----------------
Nit: it won't have any impact right now, but can you guard this declaration with LLVM_ENABLE_THREADS?

That would lead to compile time failures instead of link-time failures if someone changes something incorrectly in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115019/new/

https://reviews.llvm.org/D115019



More information about the llvm-commits mailing list