[PATCH] D114065: [Bazel] Set the right default for LLVM_WINDOWS_PREFER_FORWARD_SLASH on Windows

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 2 17:36:41 PST 2021


GMNGeoffrey updated this revision to Diff 391507.
GMNGeoffrey added a comment.

Diff against the right base


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114065/new/

https://reviews.llvm.org/D114065

Files:
  utils/bazel/llvm-project-overlay/llvm/config.bzl
  utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h


Index: utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h
===================================================================
--- utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h
+++ utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/config.h
@@ -35,6 +35,10 @@
 /* Define to 1 to enable crash memory dumps, and to 0 otherwise. */
 #define LLVM_ENABLE_CRASH_DUMPS 0
 
+/* Define to 1 to prefer forward slashes on Windows, and to 0 prefer
+   backslashes. */
+#define LLVM_WINDOWS_PREFER_FORWARD_SLASH 0
+
 /* Define to 1 if you have the `backtrace' function. */
 /* HAVE_BACKTRACE defined in Bazel */
 
Index: utils/bazel/llvm-project-overlay/llvm/config.bzl
===================================================================
--- utils/bazel/llvm-project-overlay/llvm/config.bzl
+++ utils/bazel/llvm-project-overlay/llvm/config.bzl
@@ -36,7 +36,6 @@
     "HAVE_STRERROR_R=1",
     "HAVE_SYSEXITS_H=1",
     "HAVE_UNISTD_H=1",
-    "LLVM_WINDOWS_PREFER_FORWARD_SLASH=0",
 ]
 
 linux_defines = posix_defines + [
@@ -71,7 +70,6 @@
     # LLVM features
     r'LTDL_SHLIB_EXT=\".dll\"',
     r'LLVM_PLUGIN_EXT=\".dll\"',
-    "LLVM_WINDOWS_PREFER_FORWARD_SLASH=1",
 ]
 
 # TODO: We should switch to platforms-based config settings to make this easier


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114065.391507.patch
Type: text/x-patch
Size: 1288 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211203/3f2f968a/attachment.bin>


More information about the llvm-commits mailing list