[PATCH] D114683: [LTO] Specify triple to address unknown binary format assertion

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 2 17:10:42 PST 2021


hubert.reinterpretcast added a comment.

Change looks okay. Specifically: The test is for bitcode embedded in Mach-O, so the change made probably doesn't affect the primary purpose of the test (since the Mach-O aspect was encoded in the first RUN line). In other words, adding the triple is not removing significant coverage for other targets.

Aside: I think the `default_triple` requirement can be removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114683/new/

https://reviews.llvm.org/D114683



More information about the llvm-commits mailing list