[PATCH] D114141: Allow DataLayout to support arbitrary pointer sizes

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added inline comments.


================
Comment at: llvm/include/llvm/IR/DataLayout.h:183
   /// Returns an error description on failure.
   Error setPointerAlignment(uint32_t AddrSpace, Align ABIAlign, Align PrefAlign,
+                            uint32_t TypeBitWidth, uint32_t IndexBitWidth);
----------------
tschuett wrote:
> Same here. Maybe keep the old functions and only add new functions with `ìnBits` in the name.
True, but this seems like a private interface?  I'd be more inclined to change the name without keeping the old function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114141/new/

https://reviews.llvm.org/D114141