[PATCH] D114832: [SROA] Improve SROA to prevent generating redundant coalescing operations.

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

I'm not familiar with the term "coalesce instructions", and it doesn't appear anywhere in SROA.cpp, could you explain that in the description?



================
Comment at: llvm/test/Transforms/SROA/alloca-struct.ll:65
+; COM: Check that there is only PHI node to select the whole value.
+; CHECK-COUNT-1: phi
 ; CHECK:         ret i64
----------------
luna wrote:
> nikic wrote:
> > Please use `update_test_checks.py`.
> Thanks for the suggestions! 
> 
> Using `update_test_checks.py` might make the test case a little fragile. This is a preview of the result (https://gist.github.com/minglotus-6/a05ac0300d8ea8204ec9eed409951b25)
> 
> To improve the current test style, maybe I can enrich it a little bit but still scrub updater output that look strict?
it's very hard to tell what changed without seeing every instruction in the function, so I'd also recommend `update_test_checks.py`. yes it's fragile, but that's kind of the point, to be able to see changes in IR


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114832/new/

https://reviews.llvm.org/D114832