[PATCH] D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 2 13:05:06 PST 2021
jrtc27 added a comment.
In D114186#3167955 <https://reviews.llvm.org/D114186#3167955>, @emaste wrote:
>> @jrtc27 and @emaste are both on board that the traditional GNU ld behavior / current 13.0.0 behavior is the future.
>
> I'm not sure if Jessica weighed in on this or not. I can confirm that after discussion and thinking about it I do think `start-stop-gc` is the appropriate end state.
I've tried to stay out of this for my own sanity, but my objection has not been about the end state which, in a world where SHF_GNU_RETAIN can be relied upon to work, is a more sensible state than historically (I would've preferred that uses that wanted the new GC behaviour use a new way of doing things rather than repurposing something that didn't do the right thing and then forcing their needs on it, breaking existing uses, but I can see and appreciate the technical reasons for doing it this way, and ignoring compatibility issues it does make more sense). My objection has been that SHF_GNU_RETAIN is not ubiquitous enough, both in terms of support and use, for the default start-stop-gc behaviour to have been changed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114186/new/
https://reviews.llvm.org/D114186
More information about the llvm-commits
mailing list