[PATCH] D114831: [NFC][regalloc] Move ExtraRegInfo and related to LiveRangeStageManager

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 2 12:17:02 PST 2021


mtrofin added a comment.

In D114831#3167768 <https://reviews.llvm.org/D114831#3167768>, @MatzeB wrote:

> I cannot shake the feeling that we should put the interfaces into a `RegAllocGreedy.h`, the interface doesn't feel generic enough for anything else (and FWIW I am not advocating to make it more generic, just set the right expectations that this is meant to be used in combination with RegAllocGreedy). And with expectations managed maybe it's good enough to just hand out a reference to `ExtraRegInfo` to some `friend` implementations of the eviction interface instead of introducing more abstractions and "Manager" classes. How do others working on the regallocs feel?

We'll want to use ExtraRegInfo & associated APIs in the ML-based implementation, hence the factoring.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114831/new/

https://reviews.llvm.org/D114831



More information about the llvm-commits mailing list