[PATCH] D114845: [llvm] [DebugInfo] DebuginfodCollection for tracking local debuginfo. (WIP)

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 2 12:01:01 PST 2021


phosek added inline comments.


================
Comment at: llvm/lib/Debuginfod/Debuginfod.cpp:228
+  std::error_code ec;
+  for (sys::fs::recursive_directory_iterator i(Twine(Path), ec), e; i != e;
+       i.increment(ec)) {
----------------
I expect this loop to be the performance bottleneck, so I think we should consider using a `ThreadPool` here as well to process files in parallel. That's the strategy used by elfutils' debuginfod as well.

This would likely require rethinking the API to allow sharing the thread pool between the file processing and request handling in D114846.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114845/new/

https://reviews.llvm.org/D114845



More information about the llvm-commits mailing list