[PATCH] D114573: [MachineVerifier] Make TiedOpsRewritten computable in MIRParser

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 2 11:38:30 PST 2021


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/CodeGen/MIRParser/MIRParser.cpp:377-381
+  else {
     Properties.reset(MachineFunctionProperties::Property::IsSSA);
+    if (AllTiedOpsRewritten)
+      Properties.set(MachineFunctionProperties::Property::TiedOpsRewritten);
+  }
----------------
Could we just handle the value independently from SSA to make the code more uniform? Should make the code slightly easier to understand (even though techically it can indeed never be true in SSA).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114573/new/

https://reviews.llvm.org/D114573



More information about the llvm-commits mailing list