[PATCH] D110776: A new hidden option test-changed=exe that calls exe after each time IR changes

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 2 10:21:17 PST 2021


aeubanks added a comment.

looks mostly good



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:186
+// or "" if none.
+std::string prepareTempFiles(SmallVector<int> &FD, ArrayRef<StringRef> SR,
+                             SmallVector<std::string> &FileName) {
----------------
these should probably be returning `llvm::Error` instead of `std::string`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110776/new/

https://reviews.llvm.org/D110776



More information about the llvm-commits mailing list