[PATCH] D114900: [fir] Add fir character builder

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/Builder/Runtime/Character.cpp:105
+
+mlir::Value fir::runtime::genCharCompare(fir::FirOpBuilder &builder,
+                                         mlir::Location loc,
----------------
rovka wrote:
> Please add a test for this (and check the Alloca and Store in it too).
Seems pretty complicated to create the right data structure by hand to trigger the alloca creation. `bbc` would be of great help here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114900/new/

https://reviews.llvm.org/D114900