[PATCH] D114223: Make ScopedPrinter interface virtual

Jayson Yan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 2 09:42:16 PST 2021


Jaysonyan marked 4 inline comments as done.
Jaysonyan added inline comments.


================
Comment at: llvm/include/llvm/Support/ScopedPrinter.h:258
+    for (const uint8_t &Item : List)
+      NumberList.emplace_back(unsigned(Item));
+    printListImpl(Label, NumberList);
----------------
jhenderson wrote:
> I don't think you need the explicit `unsigned` conversion, right?
You're right, removed the conversion. Thanks for the catch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114223/new/

https://reviews.llvm.org/D114223



More information about the llvm-commits mailing list