[PATCH] D114950: [RISCV] Promote large integers to constant pool

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:169
+  // Since there is no data race, the chain could be the entry node.
+  return CurDAG->getMachineNode(RISCV::LD, DL, VT, Addr, Offset,
+                                CurDAG->getEntryNode());
----------------
craig.topper wrote:
> LD assumes VT is MVT::i64. Should we assert that?
This needs a MemOperand to be added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114950/new/

https://reviews.llvm.org/D114950