[PATCH] D97673: [RFC] [[Coroutine] [Debug] Salvage dbg.values

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:2515
+    if (auto *InsertPt = dyn_cast<Instruction>(Storage))
+      DVI->moveAfter(InsertPt);
+    else if (isa<Argument>(Storage))
----------------
hoy wrote:
> I've seen this caused issue when `Storage` is a block terminator, e.g, an invoke instruction returning a piece of allocated memory. I don't quite get the full context of how we are salvaging debug info, but do you think we can just skip such case here?
Not my patch, but do you have a reproducer for this? I'm not sure what circumstances are causing `Storage` to be a block terminator, but it doesn't sound like something that should happen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97673/new/

https://reviews.llvm.org/D97673