[PATCH] D114558: [ASan] Shared optimized callbacks implementation.

Kirill Stoimenov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 2 08:26:42 PST 2021


kstoimenov added inline comments.


================
Comment at: compiler-rt/lib/asan/tests/asan_noinst_test.cpp:351
+
+#if defined(SHADOW_OFFSET_STR)
+TEST(AddressSanitizer, TestShadowGlobalVar) {
----------------
kstoimenov wrote:
> vitalybuka wrote:
> > I see  SHADOW_OFFSET_STR neither in existing code nor in the patch
> > Is some file is missing or another patch.
> It is supposed to be SHADOW_OFFSET. Good catch. 
Correction: 
It should be SHADOW_OFFSET_CONST.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114558/new/

https://reviews.llvm.org/D114558



More information about the llvm-commits mailing list