[PATCH] D114874: Support target Assemblers without a zero directive

[Boris Boesler via Phabricator via llvm-commits]

borisboesler added a comment.



In D114874#3166973 <https://reviews.llvm.org/D114874#3166973>, @daltenty wrote:

> Thanks for fixing this. Can you provide a test case for one of the targets which doesn't initialize `ZeroDirective`?

All targets support a `ZeroDirective`; its initial value is `"\t.zero\t"` and some targets overwrite it with `"\t.space\t"`or `"\t.skip\t"` or `".b8"`. My out of source target does not support such a directive.

What would the result of the target tests be, if I set `ZeroDirective = nullptr;` in each target? Do the test expect a `.zero` or similar?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114874/new/

https://reviews.llvm.org/D114874