[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

Thu Dec 2 07:15:04 PST 2021

b-sumner added a comment.

In D114957#3166882 <https://reviews.llvm.org/D114957#3166882>, @yaxunl wrote:

> In D114957#3166861 <https://reviews.llvm.org/D114957#3166861>, @arsenm wrote:
>
>> In D114957#3166858 <https://reviews.llvm.org/D114957#3166858>, @yaxunl wrote:
>>
>>> In D114957#3166817 <https://reviews.llvm.org/D114957#3166817>, @foad wrote:
>>>
>>>> This is a flag-day change to the signatures of the LLVM intrinsics and the OpenCL builtins. Is that OK?
>>>
>>> This breaks users' code. If we have to do this, at least let clang emit a pre-defined macro e.g. `__amdgcn_bvh_use_vec3__`=1 so that users can make their code work before and after the change.
>>
>> I do not think it's worth introducing a macro for this. Are there actually C users of these builtins?
>
> Yes we have users who use these clang builtins. We have received quite a few complaints about making breaking API changes without a way to detect them in the program.

But builtins are not part of the documented API and we have advised developers using them that they are subject to change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114957/new/

https://reviews.llvm.org/D114957