[PATCH] D114223: Make ScopedPrinter interface virtual

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/include/llvm/Support/ScopedPrinter.h:258
+    for (const uint8_t &Item : List)
+      NumberList.emplace_back(unsigned(Item));
+    printListImpl(Label, NumberList);
----------------
I don't think you need the explicit `unsigned` conversion, right?


================
Comment at: llvm/include/llvm/Support/ScopedPrinter.h:277
+    for (const int8_t &Item : List)
+      NumberList.emplace_back(int(Item));
+    printListImpl(Label, NumberList);
----------------
Ditto (for the `int` conversion).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114223/new/

https://reviews.llvm.org/D114223