[PATCH] D114840: [NFC] move GNUELFDumper::printEnum() into a common header for reuse.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 2 00:46:42 PST 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good! I originally wondered about this, as the behaviour doesn't seem really related to `ScopedPrinter`, but the `EnumEntry` class is defined in the same function, so I think this is the right place for it. Could you take a look at D114684 <https://reviews.llvm.org/D114684> and see if there are any additional unit tests that could be added whilst you're doing this? (I'm thinking it would be good to add some, but could be a separate patch, depending on the order in which that and this patch land).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114840/new/

https://reviews.llvm.org/D114840



More information about the llvm-commits mailing list