[PATCH] D114141: Allow DataLayout to support arbitrary pointer sizes

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: llvm/include/llvm/IR/DataLayout.h:101
   static PointerAlignElem get(uint32_t AddressSpace, Align ABIAlign,
-                              Align PrefAlign, uint32_t TypeByteWidth,
-                              uint32_t IndexWidth);
+                              Align PrefAlign, uint32_t TypeBitWidth,
+                              uint32_t IndexBitWidth);
----------------
This is dangerous. You are changing the meaning without changing the names?!? Maybe 2 versions of `get`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114141/new/

https://reviews.llvm.org/D114141