[PATCH] D114841: [lld-macho] Fix duplicate symbols with relocatable objects
Keith Smiley via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 1 18:03:36 PST 2021
keith added a comment.
I pushed another solution here that is pretty complex but I think covers the intended logic. The gist is:
1. If something is loaded implicitly, that can happen any number of times
2. If something is loaded implicitly, and then explicitly, that's fine, the implicit loads can still happen any number of times
3. If something is loaded explicitly, and then implicitly, that's fine, the implicit loads can still happen any number of times
4. If something is loaded explicitly multiple times, that is not fine, regardless of implicit loads
Note that for 2 and 3 the only difference is order based on whether the object file comes first or the `-framework` flag.
I would be interested in hearing how other folks think we can simplify this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114841/new/
https://reviews.llvm.org/D114841
More information about the llvm-commits
mailing list