[PATCH] D114582: [SDAG] Refine MMO size when converting masked load/store to normal load/store

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10117
+        MLD->getOriginalAlign(), MLD->getAAInfo(), MLD->getRanges());
     SDValue NewLd = DAG.getLoad(N->getValueType(0), SDLoc(N), MLD->getChain(),
+                                MLD->getBasePtr(), MMO);
----------------
Can we just one of the other signatures of getLoad and let it rebuild the MMO? Like this one

```
SDValue SelectionDAG::getLoad(EVT VT, const SDLoc &dl, SDValue Chain,            
                              SDValue Ptr, MachinePointerInfo PtrInfo,           
                              MaybeAlign Alignment,                              
                              MachineMemOperand::Flags MMOFlags,                 
                              const AAMDNodes &AAInfo, const MDNode *Ranges)
```

Or is there a risk that MemVT and VT don't match?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114582/new/

https://reviews.llvm.org/D114582