[PATCH] D114894: [unroll] Fix a functional change in an NFC patch

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 1 12:48:16 PST 2021


dsanders added a comment.

In D114894#3165130 <https://reviews.llvm.org/D114894#3165130>, @fhahn wrote:

> Do you have a test case by any chance that would show the functional change?

Unfortunately no. We didn't try to make a reproducer, we just have some CI compiling some internal test apps that's very strict about changes to the metrics it's tracking. Once we'd bisected the report to 5c77aa2b917c <https://reviews.llvm.org/rG5c77aa2b917c5b21b3f9c6d355ca2f9a0a81b95d> we found that the 'binary is different' flag was being set for some of the tests even though the commit said NFC

> oops, thanks. LGTM.

No problem, thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114894/new/

https://reviews.llvm.org/D114894



More information about the llvm-commits mailing list