[PATCH] D114860: [llvm-c] Make LLVMAddAlias opaque pointer compatible

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D114860#3164905 <https://reviews.llvm.org/D114860#3164905>, @aeubanks wrote:

> I think deleting functions with proper alternatives is fine, probably one at a time though so people can work through updating calls to those functions.

Even if there's no way to communicate to all users that the original is deprecated (because they might be calling it through FFI in another language that doesn't consume the C header) there's probably still some amount of C header usage - so I think marking it as deprecated for a release & documenting it in the release notes, then removing it, seems suitable. Gives people at least /some/ chance to migrate on their own timeline rather than making it a hard break from the moment the new API is introduced with no chance of decoupling the transition. (also means even if you don't find out about the issue until you upgrade to a version missing the API - you can do a patch to your mainline that adopts the new API prior to picking up the breaking version - even if it's just minutes/hours/etc it decouples the release process a bit/doesn't make it such a monolithic change, which is good)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114860/new/

https://reviews.llvm.org/D114860