[PATCH] D114894: [unroll] Fix a functional change in an NFC patch

[Daniel Sanders via Phabricator via llvm-commits]

dsanders created this revision.
dsanders added a reviewer: reames.
Herald added subscribers: zzheng, hiraditya.
dsanders requested review of this revision.
Herald added a project: LLVM.

5c77aa2b917c <https://reviews.llvm.org/rG5c77aa2b917c5b21b3f9c6d355ca2f9a0a81b95d> [unroll] Use early return in shouldFullUnroll [nfc]
wasn't quite NFC since !(x <= y) is x > y rather than x >= y

Credit to Justin Bogner for spotting the bug


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114894

Files:
  llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp


Index: llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp
+++ llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp
@@ -808,7 +808,7 @@
     const TargetTransformInfo::UnrollingPreferences &UP) {
   assert(FullUnrollTripCount && "should be non-zero!");
 
-  if (FullUnrollTripCount >= UP.FullUnrollMaxCount)
+  if (FullUnrollTripCount > UP.FullUnrollMaxCount)
     return None;
 
   // When computing the unrolled size, note that BEInsns are not replicated


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114894.391092.patch
Type: text/x-patch
Size: 562 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211201/e39a8691/attachment.bin>