[PATCH] D114889: [GlobalOpt] Simplify CleanupConstantGlobalUsers()

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:307
+      // A load from zeroinitializer is always zeroinitializer, regardless of
+      // any applied offset.
+      if (Init->isNullValue()) {
----------------
aeubanks wrote:
> is this true for non-inbounds GEPs?
Yes, because the result is either zero or the load is UB. This is similar to the logic in https://github.com/llvm/llvm-project/blob/b1bc627e7e9965e6ec15e106ee4b2c21f6c36923/llvm/lib/Analysis/ConstantFolding.cpp#L704.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114889/new/

https://reviews.llvm.org/D114889