[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

[Patryk Wychowaniec via Phabricator via llvm-commits]

Patryk27 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRFrameLowering.cpp:320
 
-      // Build the instruction sequence.
-      BuildMI(MBB, MI, DL, TII.get(AVR::SPREAD), AVR::R31R30).addReg(AVR::SP);
+  if (Opcode == TII.getCallFrameSetupOpcode()) {
+    // Update the stack pointer.
----------------
Besides adding an early exit a few lines above, this logic was not changed - Phabricator seems to have a hard time figuring out whitespaces in the diff


================
Comment at: llvm/test/CodeGen/AVR/pseudo/STDWSPQRr.mir:17
+    ; CHECK: STDPtrQRr $r31r30, 10, $r9
+    ; CHECK-NEXT: STDPtrQRr $r31r30, 11, $r10
+
----------------
Shouldn't those two also have `implicit-dif $sp`? It looks like the codegen drops it somewhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114611/new/

https://reviews.llvm.org/D114611