[PATCH] D113520: [SROA] Spill alloca's around non-capturing escapes via calls to allow alloca partitioning/promotion

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D113520#3164812 <https://reviews.llvm.org/D113520#3164812>, @reames wrote:

> @lebedev.ri Your suggested approach makes sense to me at a basic level. Forming the alloca is starting to seem more and more like a hack, but we can come back to implementing partial mem2reg as a follow on code improvement.



> A couple of suggestions:



> - Please leave taint tracking to later patch.  Start with the requirement that the non-escaping call use must also be readonly in that argument.

That was my plan, yes.

> - Instead of having the cloned alloca be the one kept, have it be the one which gets mem2reged.  That is, duplicate all the uses (except the escaping call) and let the code handle it.  The primary point here is just to keep the naming in the IR more obvious.  :)

Yeah, i was wondering about that, but didn't do that yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113520/new/

https://reviews.llvm.org/D113520